Skip to content

Web: Fix CAN options visibility for non-CAN boards#227

Open
garvit000 wants to merge 2 commits intoArduPilot:mainfrom
garvit000:clean-can-fix
Open

Web: Fix CAN options visibility for non-CAN boards#227
garvit000 wants to merge 2 commits intoArduPilot:mainfrom
garvit000:clean-can-fix

Conversation

@garvit000
Copy link

This PR fixes #151 where the "CAN" feature category remained visible even when selecting a board that does not support CAN.
Changes:

Test Plan:

  • Select "CubeOrange" → Verify "CAN" category is visible
  • Select "KakuteF4-Mini" → Verify "CAN" category is hidden

Supersedes #209 with a cleaner implementation addressing all review feedback.

Closes #151

@shiv-tyagi
Copy link
Member

Before I do a review, can you please tell did you test it? And what cases did you cover?

Also, it is generally not recommended to close existing PRs without a good reason. We lose review history that way.

@garvit000
Copy link
Author

@shiv-tyagi Yes I tested it with cubeorange and mupilot where CAN was visible and kakutef4mini where CAN was hidden.
The categories are refreshing when switching boards, also I have just pushed an extra commit to follow all hwdef include directives fixing detection for mupilot.
Regarding the PR I apologize for closing it without discussion, should i reopen it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dont present CAN items if CAN is not present in hwdef

2 participants

Comments