fix: replace CircleCI env vars in post-release Slack notifications#230
Merged
fix: replace CircleCI env vars in post-release Slack notifications#230
Conversation
adekbadek
force-pushed
the
fix/post-release-slack-messages
branch
from
a0c3110 to
a313947
Compare
Also removes duplicate root-level scripts (post-release.sh, release-wporg.sh) in favor of scripts/github/ versions, and updates the legacy CircleCI job reference in src/jobs/post-release.yml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adekbadek
force-pushed
the
fix/post-release-slack-messages
branch
from
a313947 to
d6aca70
Compare
miguelpeixe
approved these changes
Apr 9, 2026
| - run: | ||
| name: Perform post-release chores | ||
| command: ./node_modules/newspack-scripts/post-release.sh | ||
| command: ./node_modules/newspack-scripts/scripts/github/post-release.sh |
Member
There was a problem hiding this comment.
This yml file is for circleci and is not used in gh actions. Now that the migration is complete we could remove src/jobs entirely.
Member
Author
There was a problem hiding this comment.
That would break the CircleCI orb, I'd say this is out of scope and can be tackled in another PR – along with making sure nothing consumes the orb anymore.
|
🎉 This PR is included in version 5.9.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$CIRCLE_PROJECT_REPONAMEand$CIRCLE_BUILD_URLwith GitHub Actions equivalents ($GITHUB_REPOSITORY,$GITHUB_SERVER_URL/…/runs/$GITHUB_RUN_ID) in post-release Slack notificationspost-release.sh,release-wporg.sh) – thescripts/github/versions are the canonical ones🤖 Generated with Claude Code