Skip to content

fix: replace CircleCI env vars in post-release Slack notifications #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adekbadek merged 1 commit into from
Apr 9, 2026
Merged

fix: replace CircleCI env vars in post-release Slack notifications #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions post-release.sh
View file
Open in desktop

This file was deleted.

49 changes: 0 additions & 49 deletions release-wporg.sh
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions scripts/github/post-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ else
else
echo '[newspack-scripts] Notifying the team on Slack.'
curl \
--data "{\"channel\":\"$SLACK_CHANNEL_ID\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"⚠️ Post-release merge to alpha failed for: \`$CIRCLE_PROJECT_REPONAME\`. Check <$CIRCLE_BUILD_URL|the build> for details.\"}}]}" \
--data "{\"channel\":\"$SLACK_CHANNEL_ID\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"⚠️ Post-release merge to alpha failed for: \`$GITHUB_REPOSITORY\`. Check <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|the build> for details.\"}}]}" \
-H "Content-type: application/json" \
-H "Authorization: Bearer $SLACK_AUTH_TOKEN" \
-X POST https://slack.com/api/chat.postMessage \
Expand All @@ -61,7 +61,7 @@ else
else
echo '[newspack-scripts] Notifying the team on Slack.'
curl \
--data "{\"channel\":\"$SLACK_CHANNEL_ID\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"⚠️ Post-release merge to \`trunk\` failed for: \`$CIRCLE_PROJECT_REPONAME\`. Check <$CIRCLE_BUILD_URL|the build> for details.\"}}]}" \
--data "{\"channel\":\"$SLACK_CHANNEL_ID\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"⚠️ Post-release merge to \`trunk\` failed for: \`$GITHUB_REPOSITORY\`. Check <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|the build> for details.\"}}]}" \
-H "Content-type: application/json" \
-H "Authorization: Bearer $SLACK_AUTH_TOKEN" \
-X POST https://slack.com/api/chat.postMessage \
Expand Down
2 changes: 1 addition & 1 deletion src/jobs/post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ steps:
- checkout_with_workspace
- run:
name: Perform post-release chores
command: ./node_modules/newspack-scripts/post-release.sh
command: ./node_modules/newspack-scripts/scripts/github/post-release.sh
Copy link
Copy Markdown
Member

@miguelpeixe miguelpeixe Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This yml file is for circleci and is not used in gh actions. Now that the migration is complete we could remove src/jobs entirely.

Copy link
Copy Markdown
Member Author

@adekbadek adekbadek Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would break the CircleCI orb, I'd say this is out of scope and can be tackled in another PR – along with making sure nothing consumes the orb anymore.

Loading