Defer CSS handling to AMP plugin when is_amp_endpoint()#41
Open
westonruter wants to merge 1 commit intoAutomattic:masterfrom
Open
Defer CSS handling to AMP plugin when is_amp_endpoint()#41westonruter wants to merge 1 commit intoAutomattic:masterfrom
westonruter wants to merge 1 commit intoAutomattic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in an AMP response, prevent needlessly concatenating and minifying CSS because the AMP plugin does this automatically; beyond this, the AMP plugin also does tree shaking to strip out CSS rules that do not apply to the current page, and the resulting CSS from external stylesheets, style elements, and style attributes is then all combined into the one
style[amp-custom]element. This check prevents the AMP plugin from having to issue an HTTP request to fetch the contents of the concatenated stylesheet.Note that this
is_amp_endpoint()check is done here at runtime instead of incss_concat_init()because it must be called after theparse_queryaction in order to determine whether the response will be served as AMP or not. Note also that this change only applies to sites that enable AMP theme support, as the classic AMP post templates do not useWP_Stylesat all.See https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support