Fetch CSS over HTTP when URL lacks extension; convert font CDN stylesheets @imports to convert to links instead of fetching#1357
Merged
westonruter merged 3 commits intodevelopfrom Aug 27, 2018
Conversation
hellofromtonya
approved these changes
Aug 27, 2018
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
Looks good. Great job @westonruter
Member
Author
|
See also Automattic/nginx-http-concat#41 which would bypasse VIP's http-concat for CSS when |
Contributor
|
Moving To 'Ready For Merging' If it's alright, I'm moving this to 'Ready For Merging,' as I don't think it needs functional testing. Feel free to move it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a stylesheet
linkwith a URL which does not end incss, fetch it over HTTP instead of throwing a validation error.Additionally, if there is a stylesheet that contains an
@importto a stylesheet URL which is whitelisted CDN for fonts such as:Then instead of fetching the CSS to inline, opt instead to convert into a normal
linktag:Fixes #1317