Closed
Conversation
Thanks for creating a PR for your Issue!
|
Contributor
Author
|
@AvishkarPatil Please check and merge the PR. |
Owner
|
@Hrusikesh001 The changes look good. It would be better if you move the filter button closer to the "Sort" button and align the UI with the web version. |
Contributor
Author
Ok I will do it |
Closed
Contributor
Author
|
please check the changes and merge the PR. @AvishkarPatil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
🎯 Rationale
Current issue matching was limited and not flexible enough.
Users couldn’t filter issues by skills/keywords, making discovery harder.
Theme consistency across dark/light mode was inconsistent.
This PR improves backend issue retrieval and frontend filtering/UI, creating a smoother developer experience.
📝 Summary of Changes
Backend
Added load_model() function for FAISS model and initialized it on app startup.
Expanded GitHub search query to include title, body, and comments (beyond labels).
Configured session middleware cookie (issuematch_session) with proper attributes.
Improved error handling and logging in auth.py and faiss_search.py.
Frontend
New Component: IssueFilter – filter issues by user skills and predefined keywords.
Integrated IssueFilter into IssuesList with dynamic queries.
Improved error state when user is not logged in (shows login prompt).
Extended API timeout from 15s → 25s for reliability.
Updated styling for skills page, skills test, and welcome screen for consistent dark/light themes.
🔧 Technical Details
No new external dependencies added.
Refactored FAISS model loading for performance and maintainability.
UI uses existing context (useAuth) and Firebase integration.
Purely additive frontend feature (IssueFilter) – no breaking changes to existing flows.
✅ Testing
Test Coverage
Manual testing completed
All existing tests pass
Test Details
Verified FAISS model loads on backend startup without errors.
Confirmed GitHub issue queries return results with expanded scope.
Tested issue filtering with both predefined skills and user skills.
Checked UI behavior in both light and dark modes.
Validated login-required prompt when accessing issues list unauthenticated.
📚 Documentation
✅ Inline code comments updated
🔄 Breaking Changes
✅ None introduced
🎨 User-Facing Changes
Frontend Changes
Added IssueFilter dropdown (skills/keywords).
Improved dark/light theme styling across skills pages and test.
Updated button, progress bar, and divider animations.
Backend/API Changes
📋 Checklist
✅ Code follows project style guidelines
✅ Self-review completed
✅ No debug statements left
✅ Error handling implemented
✅ PR title and description are descriptive
✅ Commits are atomic and documented
✅Branch is up to date with main
🚀 Deployment Notes
📸 Screenshots/Demo
🙏 Reviewer Notes
Please pay attention to FAISS model initialization (moved to startup).
Review the IssueFilter integration for possible improvements.
Styling tweaks tested manually, feedback on theme consistency appreciated.
@AvishkarPatil Could you please review and let me know if it looks good?
Please check and merge the PR