feat(auth): let users choose GitHub OAuth scopes (limit repo access) #43#57
Closed
kashifalikhan36 wants to merge 2 commits intoAvishkarPatil:mainfrom
Closed
feat(auth): let users choose GitHub OAuth scopes (limit repo access) #43#57kashifalikhan36 wants to merge 2 commits intoAvishkarPatil:mainfrom
kashifalikhan36 wants to merge 2 commits intoAvishkarPatil:mainfrom
Conversation
Implements frontend UI for users to choose which GitHub OAuth scopes to grant, with backend validation against an allow-list. The login and profile pages now display requested and granted scopes, and documentation has been added to explain each scope and recommended usage. Tests ensure invalid scopes are rejected and valid ones are accepted.
Added a _debug_login.py script for manual login endpoint testing. Updated test_auth_scopes.py to avoid following external redirects and clarified assertions. Provided safe default values for sensitive config variables in config.py to ease local development and testing, and improved debug logging to avoid printing secrets.
Thanks for creating a PR for your Issue!
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a scoped OAuth flow and UI so users can pick which GitHub scopes to grant instead of requesting full repo access. This respects user privacy and makes the app request only what it needs.
Related Issue
Closes #43
What changed
How to test
current repo:status is sufficient for commit-status features and does NOT grant repo code access. repo grants broad access (including private repo code).
Actually, i wanted to recommended and for making a another issue [Feature update]: add a settings/revoke UI and/or a re-authorize flow to change scopes later.