cleanup(webview): drop trivial DEBUG-only overrides in LoggingWebChromeClient (#422)#805
Open
jim-daf wants to merge 2 commits intoAwful:developfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes trivial DEBUG-only WebChromeClient overrides that only logged and forwarded to super, reducing log spam and dead code in LoggingWebChromeClient.
Changes:
- Deleted DEBUG-only overrides:
onCloseWindow,onCreateWindow, andonJsTimeout - Kept non-trivial overrides (
onConsoleMessage, custom view handling) intact
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
40
to
41
| this.webView = webView; | ||
| } |
There was a problem hiding this comment.
After removing the onCreateWindow(..., Message resultMsg) override, the android.os.Message import becomes unused (and the PR description mentions it should be removed). Please delete that import so the file stays clean and matches the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #422.
The issue raises the question of whether the trivial DEBUG-only overrides in
LoggingWebChromeClient(onCloseWindow,onCreateWindow,onJsTimeout) earn their keep. They each exist solely to callLog.dthen forward to super. The author leaned toward dropping them until there is an actual bug to chase. This PR does that and also removes the now-unusedandroid.os.Messageimport.onConsoleMessage,onShowCustomView, andonHideCustomViewstay as-is because they actually do work.If anyone wants this logging back later, the methods are five lines and trivial to restore.