Skip to content

cleanup(webview): drop trivial DEBUG-only overrides in LoggingWebChromeClient (#422) #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

cleanup(webview): drop trivial DEBUG-only overrides in LoggingWebChromeClient (#422) #805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e6455
cleanup(webview): drop trivial DEBUG-only overrides
jim-daf Apr 25, 2026
d5bff59
cleanup(webview): drop trivial DEBUG-only overrides
jim-daf Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,28 +40,6 @@ public LoggingWebChromeClient(WebView webView) {
this.webView = webView;
}
Comment on lines 40 to 41
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the onCreateWindow(..., Message resultMsg) override, the android.os.Message import becomes unused (and the PR description mentions it should be removed). Please delete that import so the file stays clean and matches the PR description.

Copilot uses AI. Check for mistakes.

@CallSuper
@Override
public void onCloseWindow(WebView window) {
super.onCloseWindow(window);
if (DEBUG) Log.d(TAG, "onCloseWindow");
}

@CallSuper
@Override
public boolean onCreateWindow(WebView view, boolean isDialog, boolean isUserGesture, Message resultMsg) {
if (DEBUG)
Log.d(TAG, "onCreateWindow" + (isDialog ? " isDialog" : "") + (isUserGesture ? " isUserGesture" : ""));
return super.onCreateWindow(view, isDialog, isUserGesture, resultMsg);
}

@CallSuper
@Override
public boolean onJsTimeout() {
if (DEBUG) Log.d(TAG, "onJsTimeout");
return super.onJsTimeout();
}

@Override
public void onShowCustomView(View view, CustomViewCallback callback) {
// if a view already exists then immediately terminate the new one
Expand Down
Loading