Do not assign _multi_output_topics when the topic is from a loader
#997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Before this PR, when running:
got error:
This PR fixes this.
The dependency tree looks like this
And
s2_photonsis not saved because itssave_whenis notALWAYS. Whendata_typeisphoto_ionization_electrons, themsgin_fetch_new("s2_photons_sum")is loaded from storage but not calculated from a plugin. In this PR, we do not assign topic that has loaders to_multi_output_topicsto prevent this error. Also, only call_ack_msg_producedwhensub_msg_topicis in_multi_output_topicsbecause ifsub_msg_topicis not in_multi_output_topics, it already has a loader.Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).