Skip to content

Do not assign _multi_output_topics when the topic is from a loader #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dachengx merged 2 commits into from
Jul 6, 2025
Merged

Do not assign _multi_output_topics when the topic is from a loader #997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e16570c
Do not assign `_multi_output_topics` when the topic is from a loader
dachengx Jul 6, 2025
b86cc45
Bug fix
dachengx Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions strax/processors/post_office.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ def register_producer(
else:
# Multi-output producer, recurse
for sub_topic in topic:
self._multi_output_topics[sub_topic] = topic
# if sub_topic is already registered as loader,
# we can not handle it as _multi_output_topics
if sub_topic not in registered:
self._multi_output_topics[sub_topic] = topic
self.register_producer(iterator, sub_topic)
return
assert isinstance(topic, str)
Expand Down Expand Up @@ -264,7 +266,10 @@ def _fetch_new(self, topic):
# This is what our caller wants
desired_sub_msg = sub_msg
log.debug(f"Got submessage {sub_msg} for sub topic {sub_msg_topic}")
self._ack_msg_produced(sub_msg, sub_msg_topic)
# sub_msg_topic not in self._multi_output_topics means
# it already has a loader (as producer)
if sub_msg_topic in self._multi_output_topics:
self._ack_msg_produced(sub_msg, sub_msg_topic)
return desired_sub_msg

def _ack_msg_produced(self, msg, topic):
Expand Down