Fix brightness slider not applying on scroll #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, this must be something recent. Let me test but it was working on my laptop. Alright, found a mouse. I can't scroll at all, so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using #211 and noticed that scroll doesn't change the brightness. It's changing the value on the slider but the values doesn't get applied to the monitor.
Turns out the "scroll-event" is not needed at all, just like with mic and volume sliders. There seems to be some race condition with the other events as going step by step with a debugger makes the brightness apply.
Step size can be changed using "increments" on slider's init if need be. First value controls the step with page up/down, the 2nd one controls the scroll step. There is a small bug where you need to press the slider with a mouse first to be able to use page up/down tho.