Skip to content

Fix brightness slider not applying on scroll #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Fix brightness slider not applying on scroll #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions modules/controls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def __init__(self, **kwargs):
self._debounce_timeout = 100

self.connect("change-value", self.on_scale_move)
self.connect("scroll-event", self.on_scroll)
self.client.connect("screen", self.on_brightness_changed)

def on_scale_move(self, widget, scroll, moved_pos):
Expand All @@ -151,26 +150,6 @@ def _update_brightness_callback(self):
self._update_source_id = None
return False

def on_scroll(self, widget, event):
current_value = self.get_value()
step_size = 1
if event.direction == Gdk.ScrollDirection.SMOOTH:
if event.delta_y < 0:
new_value = min(current_value + step_size, self.client.max_screen)
elif event.delta_y > 0:
new_value = max(current_value - step_size, 0)
else:
return False
else:
if event.direction == Gdk.ScrollDirection.UP:
new_value = min(current_value + step_size, self.client.max_screen)
elif event.direction == Gdk.ScrollDirection.DOWN:
new_value = max(current_value - step_size, 0)
else:
return False
self.set_value(new_value)
return True

def on_brightness_changed(self, client, _):
self._updating_from_brightness = True
self.set_value(self.client.screen_brightness)
Expand Down