e2e: fix admin credential lifecycle skip guard for integration/parallel#4161
e2e: fix admin credential lifecycle skip guard for integration/parallel#4161avollmer-redhat wants to merge 1 commit intomainfrom
Conversation
Commit d38165a introduced skip guards across three steps of the admin credential lifecycle test to work around ARO-23882 in the integration/parallel suite until 2026-03-11. However, the final skip guard (verifying that a newly-issued credential works post-revocation) was incorrectly gated on `skipInt`, a flag only set when the revocation wait loop itself times out. On the Feb 19 2026 run, credential revocation completed successfully for all three credentials within the 5-minute window, so `skipInt` remained false. The final skip guard therefore had no effect, and the test failed when the newly-issued credential returned 401 Unauthorized — the same underlying issue (ARO-23882 / OCPBUGS-62177) that the skip was meant to paper over. Previous runs between Feb 12-18 happened to pass because at least one credential took longer than 5 minutes to revoke, setting `skipInt=true` accidentally triggering the skip. That is: the test was passing for the wrong reason. Remove the `skipInt &&` condition so the final skip guard mirrors the other two guards and unconditionally skips in integration/parallel until the deadline.
avollmer-redhat
force-pushed
the
fix-admin-cred-lifecycle-skip-guard
branch
from
6a6eab9 to
661d925
Compare
|
@avollmer-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold We did NOT want to skip any other part of the test, that is on purpose. This is a novel and concerning issue unrelated to the original one. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avollmer-redhat, miquelsi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What
Commit d38165a introduced skip guards across three steps of the admin credential lifecycle test to work around ARO-23882 in the integration/parallel suite until 2026-03-11. However, the final skip guard (verifying that a newly-issued credential works post-revocation) was incorrectly gated on
skipInt, a flag only set when the revocation wait loop itself times out.Why
On the Feb 19 2026 run, credential revocation completed successfully for all three credentials within the 5-minute window, so
skipIntremained false. The final skip guard therefore had no effect, and the test failed when the newly-issued credential returned 401 Unauthorized — the same underlying issue (ARO-23882 / OCPBUGS-62177) that the skip was meant to paper over.Previous runs between Feb 12-18 happened to pass because at least one credential took longer than 5 minutes to revoke, setting
skipInt=trueaccidentally triggering the skip. That is: the test was passing for the wrong reason.Remove the
skipInt &&condition so the final skip guard mirrors the other two guards and unconditionally skips in integration/parallel until the deadline.