Skip to content

e2e: fix admin credential lifecycle skip guard for integration/parallel #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avollmer-redhat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

e2e: fix admin credential lifecycle skip guard for integration/parallel #4161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/e2e/admin_credential_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ var _ = Describe("Customer", func() {
}

By("validating all admin credentials now fail after revocation")
skipInt := false
for i, cred := range credentials {
By(fmt.Sprintf("verifying admin credential %d now fails", i+1))
// TODO(bvesel) remove once OCPBUGS-62177 is implemented
Expand Down Expand Up @@ -231,7 +230,6 @@ var _ = Describe("Customer", func() {
})
if err != nil && os.Getenv("ARO_HCP_SUITE_NAME") == "integration/parallel" && time.Now().Before(time.Date(2026, 3, 11, 0, 0, 0, 0, time.UTC)) {
By("skipping in integration/parallel suite")
skipInt = true
break
} else {
Expect(err).NotTo(HaveOccurred(), "Admin credential %d should fail after revocation, last error: %v", i+1, lastError)
Expand All @@ -252,7 +250,7 @@ var _ = Describe("Customer", func() {
Expect(newAdminRESTConfig).NotTo(BeNil())

By("verifying new admin credentials work after revocation")
if skipInt && os.Getenv("ARO_HCP_SUITE_NAME") == "integration/parallel" && time.Now().Before(time.Date(2026, 3, 11, 0, 0, 0, 0, time.UTC)) {
if os.Getenv("ARO_HCP_SUITE_NAME") == "integration/parallel" && time.Now().Before(time.Date(2026, 3, 11, 0, 0, 0, 0, time.UTC)) {
By("skipping in integration/parallel suite")
} else {
Expect(verifiers.VerifyHCPCluster(ctx, newAdminRESTConfig)).To(Succeed(), "New admin credentials should work after revocation")
Expand Down