Conversation
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables Active Directory-based authentication by commenting out the conditional logic that sets different auth token callbacks based on the aznfsc_cfg.auth flag. Instead, it always sets the callback to get_auth_token_and_setargs_cb_none, which represents no authentication. The change is made with the stated intention to re-enable authentication when TLS support is added.
Changes:
- Commented out the conditional authentication logic that checked
aznfsc_cfg.auth - Added an explanatory comment about disabling AAD/AD authentication until TLS support is available
- Set the auth token callback to unconditionally use the "none" variant
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| if (aznfsc_cfg.auth) { | ||
| // Disable AAD based auth for now. We will enable this when we support auth with TLS. |
There was a problem hiding this comment.
The comment refers to "AAD based auth" but should say "AD based auth" to match the PR title, or clarify if this is Azure Active Directory (AAD) or Active Directory (AD). The inconsistency between the comment and PR title could cause confusion.
| // Disable AAD based auth for now. We will enable this when we support auth with TLS. | |
| // Disable Azure Active Directory (AAD) based auth for now. We will enable this when we support auth with TLS. |
|
|
||
| }*/ | ||
| set_auth_token_callback(get_auth_token_and_setargs_cb_none); | ||
|
|
There was a problem hiding this comment.
There is a tab character at the end of this line. This should be removed to maintain consistent whitespace formatting.
There was a problem hiding this comment.
@pragyagandhi Canou make change to bool aznfsc_cfg::set_defaults_and_sanitize()
and set xprtsec always to none. Then you don't need this change.
|
|
||
| if (aznfsc_cfg.auth) { | ||
| // Disable AAD based auth for now. We will enable this when we support auth with TLS. | ||
| /* if (aznfsc_cfg.auth) { |
There was a problem hiding this comment.
The indentation is inconsistent. The commented-out code uses proper indentation, but the opening comment marker has a space instead of tab or proper indentation alignment.
| /* if (aznfsc_cfg.auth) { | |
| /* if (aznfsc_cfg.auth) { |
2 participants
No description provided.