Skip to content

Disable AD based auth #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pragyagandhi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Disable AD based auth #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebf4c4b
Updated
Jan 14, 2026
198012d
Minor update
Jan 14, 2026
30bef12
Revert "Minor update"
Jan 14, 2026
fb7aba3
Updated
Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions turbonfs/src/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,8 @@ bool aznfsc_cfg::set_defaults_and_sanitize()
::freeaddrinfo(ai);
}

if (xprtsec == nullptr)
xprtsec = ::strdup("none");
// Set xprtsec to none for now, by default.
xprtsec = ::strdup("none");

assert(account != nullptr);
assert(container != nullptr);
Expand Down
8 changes: 5 additions & 3 deletions turbonfs/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,13 +832,15 @@ int main(int argc, char *argv[])
goto err_out4;
}

if (aznfsc_cfg.auth) {
// Disable AAD based auth for now. We will enable this when we support auth with TLS.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment refers to "AAD based auth" but should say "AD based auth" to match the PR title, or clarify if this is Azure Active Directory (AAD) or Active Directory (AD). The inconsistency between the comment and PR title could cause confusion.

Suggested change
// Disable AAD based auth for now. We will enable this when we support auth with TLS.
// Disable Azure Active Directory (AAD) based auth for now. We will enable this when we support auth with TLS.

Copilot uses AI. Check for mistakes.
/* if (aznfsc_cfg.auth) {
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent. The commented-out code uses proper indentation, but the opening comment marker has a space instead of tab or proper indentation alignment.

Suggested change
/* if (aznfsc_cfg.auth) {
/* if (aznfsc_cfg.auth) {

Copilot uses AI. Check for mistakes.
// Set the auth token callback for this connection if auth is enabled.
set_auth_token_callback(get_auth_token_and_setargs_cb);
} else {
set_auth_token_callback(get_auth_token_and_setargs_cb_none);
}

}*/
set_auth_token_callback(get_auth_token_and_setargs_cb_none);

Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tab character at the end of this line. This should be removed to maintain consistent whitespace formatting.

Suggested change

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@nitin-deamon nitin-deamon Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pragyagandhi Canou make change to bool aznfsc_cfg::set_defaults_and_sanitize()
and set xprtsec always to none. Then you don't need this change.

/*
* Initialize nfs_client singleton.
* This creates the libnfs polling thread(s) and hence it MUST be called
Expand Down