Skip to content

Conversation

@WhiteTomX
Copy link

Issue describing the changes in this PR

I wondered why I'm asked for the worker runtime, although it told me the local.settings.json was found. Turns out it is a new clone and the file is not there. The output is just wrong.

local.settings.json found in root directory (C:\Users\WhiteTom\src\api).
Use the up/down arrow keys to select a worker runtime:
dotnet (isolated worker model)
dotnet (in-process model)
Node
Python
Powershell
Custom

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
    • Or should they be added to release notes?
  • I have added all required tests (Unit tests, E2E tests)
    • I don't think tests are required for that?

As the method only combines the path, we are not sure it is found.
@WhiteTomX WhiteTomX requested a review from a team as a code owner October 27, 2025 20:10
@WhiteTomX
Copy link
Author

I made the easy change to just change the wording. The alternative would be to remove the output there and output if the file was actually loaded or not. Currently we only output if the file is there, but not a valid json.

var secretsFilePath = Path.Combine(rootPath, secretsFile);

ColoredConsole.WriteLine(DarkGray($"'{secretsFile}' found in root directory ({rootPath})."));
ColoredConsole.WriteLine(DarkGray($"'{secretsFile}' should be in root directory ({rootPath})."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this issue!

This isn't the intention of this log here - it should be logging if it did find a local.settings file, and not notifying were it should be. If this isn't working as intended feel free to file an issue and we can investigate what's actually happening to fix it. You're also welcome to take a stab at this yourself but chaning the verbiage of the log here isn't the approach I would like us to take.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. It should be quite straight forward to fix that. I hope I will be able to do so at the weekend.

@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants