Skip to content

fix: outputs local.settings.json found even though it isnt #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: outputs local.settings.json found even though it isnt #4694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/func/Common/SecretsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static string AppSettingsFilePath
});
var secretsFilePath = Path.Combine(rootPath, secretsFile);

ColoredConsole.WriteLine(DarkGray($"'{secretsFile}' found in root directory ({rootPath})."));
ColoredConsole.WriteLine(DarkGray($"'{secretsFile}' should be in root directory ({rootPath})."));
Copy link
Member

@liliankasem liliankasem Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this issue!

This isn't the intention of this log here - it should be logging if it did find a local.settings file, and not notifying were it should be. If this isn't working as intended feel free to file an issue and we can investigate what's actually happening to fix it. You're also welcome to take a stab at this yourself but chaning the verbiage of the log here isn't the approach I would like us to take.

Copy link
Author

@WhiteTomX WhiteTomX Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. It should be quite straight forward to fix that. I hope I will be able to do so at the weekend.

return secretsFilePath;
}
}
Expand Down