Open
Conversation
tallaxes
requested changes
May 4, 2025
tallaxes
left a comment
tallaxes
left a comment
There was a problem hiding this comment.
The generate part looks good, the regex update needs fixing - and maybe a separate PR?
|
|
||
| var skuSizeScheme = regexp.MustCompile( | ||
| `^([A-Z])([A-Z]?)([0-9]+)-?((?:[0-9]+)?)((?:[abcdilmtspPr]+|C+|NP)?)_?(?:([A-Z][0-9]+)_?)?(_cc_)?((?:[vV][1-9])?)?(_Promo)?$`, | ||
| `^([A-Z])([A-Z]?)([A-Z]?)([0-9]+)-?((?:[0-9]+)?)((?:[abcdeilmtspPr]+|C+|NP)?)_?(?:([A-Z][0-9]+)_?)?(_cc_)?(_[0-9]+_)?(_MI300X_)?(_H100_)?((?:[vV][1-9])?)?(_Promo)?$`, |
There was a problem hiding this comment.
Seems to have broken the associated tests - likely due to introduction of new groups, which shifts group numbers referenced in tests?
Member
Author
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
jackfrancis
force-pushed
the
generate-sku-data
branch
from
870d59e to
6e6ef82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Azure resource API generator to include compute.SKU-formatted data, easily ingested by the Karpenter Azure provider. This enables easy maintenance of this generated list going forward in the event we want to include runtime VM SKU filtering for karpenter-provider-azure:
Includes updated generated data against Azure public cloud from region westus2.