Issue #2848264: Implement admin permission to restrict access to Stock admin page(s) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoliver
force-pushed
the
2848264-admin-permission
branch
from
a95ef73 to
6667371
Compare
steveoliver
force-pushed
the
2848264-admin-permission
branch
from
6667371 to
94f3cd1
Compare
BBGuy
reviewed
Feb 15, 2017
| _title: 'Create stock transaction' | ||
| requirements: | ||
| _access: 'TRUE' | ||
| _permission: 'administer commerce_stock' |
Owner
There was a problem hiding this comment.
Creating transactions should not be for stock admins especially as this is one of the 3 Entry systems the stock field supports.
Contributor
Author
There was a problem hiding this comment.
Yes, but we certainly shouldn't grant everyone access to this route. :)
Owner
There was a problem hiding this comment.
That is also true. Should probably be the same permission that allows editing of products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.drupal.org/node/2848264.