Skip to content

Issue #2848264: Implement admin permission to restrict access to Stock admin page(s) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steveoliver wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

Issue #2848264: Implement admin permission to restrict access to Stock admin page(s) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions commerce_stock.permissions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
'administer commerce_stock':
title: 'Administer Commerce Stock'
description: 'Use Commerce Stock administrative pages and functionality.'
'restrict access': TRUE
2 changes: 1 addition & 1 deletion commerce_stock.routing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ commerce_stock.stock_config:
_form: '\Drupal\commerce_stock\Form\StockConfigForm'
_title: 'Configure Commerce Stock'
requirements:
_permission: 'access administration pages'
_permission: 'administer commerce_stock'
options:
_admin_route: TRUE
4 changes: 2 additions & 2 deletions modules/ui/commerce_stock_ui.routing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ commerce_stock_ui.stock_transactions1:
_form: '\Drupal\commerce_stock_ui\Form\StockTransactions1'
_title: 'Create stock transaction'
requirements:
_access: 'TRUE'
_permission: 'administer commerce_stock'
Copy link
Owner

@BBGuy BBGuy Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating transactions should not be for stock admins especially as this is one of the 3 Entry systems the stock field supports.

Copy link
Contributor Author

@steveoliver steveoliver Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we certainly shouldn't grant everyone access to this route. :)

Copy link
Owner

@BBGuy BBGuy Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is also true. Should probably be the same permission that allows editing of products


commerce_stock_ui.stock_transactions2:
path: '/admin/commerce/config/stock/transactions2'
defaults:
_form: '\Drupal\commerce_stock_ui\Form\StockTransactions2'
_title: 'Create stock transaction'
requirements:
_access: 'TRUE'
_permission: 'administer commerce_stock'
1 change: 1 addition & 0 deletions tests/src/Functional/StockBrowserTestBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ protected function getAdministratorPermissions() {
'administer commerce_product_variation fields',
'administer commerce_product_variation display',
'access commerce_product overview',
'administer commerce_stock',
], parent::getAdministratorPermissions());
}

Expand Down