feat(express): migrate signpayload to typed routes #6942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
requested changes
Sep 10, 2025
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Looks like there is some CI errors as well
Added UT to test/unit/clientRoutes/signPayload.tsAlso it seems like this migration makes the UT for `Sign an arbitrary payload with trading account key` (ticket: https://bitgoinc.atlassian.net/browse/GO-1015) to pass. TICKET: WP-5443
Taseen08
previously approved these changes
Sep 11, 2025
zahin-mohammad
requested changes
Sep 17, 2025
update regex for raw trx hex validation
feat(statics): onboard new bsc token
feat: PR from asset-metadata-service for token onboardings
feat(sdk-coin-ton): add jetton transaction support
feat(sdk-coin-ada): token build support
feat: replace apt usd1 asset id with fungible asset address
chore: Adding EVM_COMPATIBLE_IMS feature to TSTT
feat: gate tokens for BitGo Singapore
…tions feat: update release workflow
fix(sdk-core): backup keychain creation to use correct privateMaterial for EcDSA MPCV2 wallets
…in-keychain-local-to-typed-routes feat(express): migrate keychainlocal to typed routes
feat: migrate advanced wallet type from subtype to type
BREAKING CHANGE: FA address gets indexed for transfers instead of move module address TICKET: TMS-1274
feat!: replace apt usd1 asset id with Fungible asset address
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
merge conflicts. re-request a review when ready
Added UT to test/unit/clientRoutes/signPayload.tsAlso it seems like this migration makes the UT for `Sign an arbitrary payload with trading account key` (ticket: https://bitgoinc.atlassian.net/browse/GO-1015) to pass. TICKET: WP-5443
…-routes' of github.com:BitGo/BitGoJS into WP-5443-express-migrate-api-v2-ofc-signPayload-to-typed-routes TICKET: WP-5443
danielzhao122
deleted the
WP-5443-express-migrate-api-v2-ofc-signPayload-to-typed-routes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed router for signPayload
Added UT: "express.ofc.signPayload" in test/unit/typedRoutes/decode.ts
TICKET: WP-5443