feat(express): migrate signpayload to typed routes

.github/workflows/ci.yml

@@ -60,9 +60,6 @@ jobs:
         if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
         run: yarn install --with-frozen-lockfile --ignore-scripts
 
-      - name: Check In-Repo Package Versions
-        run: yarn run check-versions
-
       - name: build packages
         env:
           # Workaround for https://github.com/nodejs/node/issues/51555

.github/workflows/publish.yml

@@ -26,7 +26,7 @@ jobs:
           node-version-file: .nvmrc
 
       - name: Install BitGoJS
-        run: yarn install --with-frozen-lockfile
+        run: yarn install --with-frozen-lockfile --ignore-scripts
 
       - name: Set Environment Variable for Alpha
         if: github.ref != 'refs/heads/master' # only publish changes if on feature branches

.gitignore

@@ -18,3 +18,4 @@ modules/**/pack-scoped/
 coverage
 /.direnv/
 .claude/
+scripts/cache/

CODEOWNERS

@@ -109,10 +109,6 @@
 /modules/sdk-core/src/bitgo/address-book/ @BitGo/prime
 /modules/sdk-core/src/bitgo/trading/ @BitGo/prime
 
-# Asset Metadata Service
-/modules/statics/src/coins/botTokens.ts @BitGo/ams
-/modules/statics/src/coins/botOfcTokens.ts @BitGo/ams
-
 # Core Modules
 /modules/bitgo/ @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform
 /modules/bitgo/test/v2/unit/lightning/ @BitGo/btc-team
@@ -141,6 +137,10 @@
 /types/ @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform
 /webpack/ @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform
 
+# Asset Metadata Service
+/modules/statics/src/coins/botTokens.ts @BitGo/ams
+/modules/statics/src/coins/botOfcTokens.ts @BitGo/ams
+
 /.eslintrc.json @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform @BitGo/developer-experience
 /.prettierrc.yml @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform @BitGo/developer-experience
 /check-package-versions.js @BitGo/coins @BitGo/web-experience @BitGo/wallet-platform @BitGo/developer-experience

lerna.json

@@ -4,7 +4,13 @@
   "useWorkspaces": true,
   "command": {
     "version": {
-      "message": "chore(root): publish modules"
+      "message": "chore(root): publish modules",
+      "allowBranch": "master",
+      "skipGit": true
+    },
+    "publish": {
+      "skipGit": true,
+      "allowBranch": "master"
     }
   },
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",

modules/abstract-cosmos/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitgo/abstract-cosmos",
-  "version": "11.14.2",
+  "version": "0.0.0-semantic-release-managed",
   "description": "BitGo SDK coin library for COSMOS base implementation",
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
@@ -38,10 +38,10 @@
     ]
   },
   "dependencies": {
-    "@bitgo/sdk-core": "^36.8.0",
-    "@bitgo/sdk-lib-mpc": "^10.7.0",
-    "@bitgo/secp256k1": "^1.5.0",
-    "@bitgo/statics": "^57.8.0",
+    "@bitgo/sdk-core": "0.0.0-semantic-release-managed",
+    "@bitgo/sdk-lib-mpc": "0.0.0-semantic-release-managed",
+    "@bitgo/secp256k1": "0.0.0-semantic-release-managed",
+    "@bitgo/statics": "0.0.0-semantic-release-managed",
     "@cosmjs/amino": "^0.29.5",
     "@cosmjs/crypto": "^0.30.1",
     "@cosmjs/encoding": "^0.29.5",

modules/abstract-eth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitgo/abstract-eth",
-  "version": "24.12.0",
+  "version": "0.0.0-semantic-release-managed",
   "description": "BitGo SDK coin library for ETH base implementation",
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
@@ -40,10 +40,10 @@
     ]
   },
   "dependencies": {
-    "@bitgo/sdk-core": "^36.8.0",
-    "@bitgo/sdk-lib-mpc": "^10.7.0",
-    "@bitgo/secp256k1": "^1.5.0",
-    "@bitgo/statics": "^57.8.0",
+    "@bitgo/sdk-core": "0.0.0-semantic-release-managed",
+    "@bitgo/sdk-lib-mpc": "0.0.0-semantic-release-managed",
+    "@bitgo/secp256k1": "0.0.0-semantic-release-managed",
+    "@bitgo/statics": "0.0.0-semantic-release-managed",
     "@ethereumjs/common": "^2.6.5",
     "@ethereumjs/rlp": "^4.0.0",
     "@ethereumjs/tx": "^3.3.0",
@@ -60,8 +60,8 @@
     "superagent": "^9.0.1"
   },
   "devDependencies": {
-    "@bitgo/sdk-api": "^1.68.3",
-    "@bitgo/sdk-test": "^9.0.9",
+    "@bitgo/sdk-api": "0.0.0-semantic-release-managed",
+    "@bitgo/sdk-test": "0.0.0-semantic-release-managed",
     "@types/keccak": "^3.0.5"
   },
   "gitHead": "18e460ddf02de2dbf13c2aa243478188fb539f0c"

modules/abstract-eth/src/lib/transactionBuilder.ts

@@ -49,6 +49,7 @@ import { Transaction } from './transaction';
 import { TransferBuilder } from './transferBuilder';
 
 const DEFAULT_M = 3;
+const RAW_TX_HEX_REGEX = /^(0x)?[0-9a-f]{1,}$/;
 
 /**
  * EthereumLike transaction builder.
@@ -165,7 +166,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
   /** @inheritdoc */
   protected fromImplementation(rawTransaction: string, isFirstSigner?: boolean): Transaction {
     let tx: Transaction;
-    if (/^0x?[0-9a-f]{1,}$/.test(rawTransaction.toLowerCase())) {
+    if (RAW_TX_HEX_REGEX.test(rawTransaction.toLowerCase())) {
       tx = Transaction.fromSerialized(this._coinConfig, this._common, rawTransaction, isFirstSigner);
       this.loadBuilderInput(tx.toJson(), isFirstSigner);
     } else {
@@ -343,7 +344,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
       throw new InvalidTransactionError('Raw transaction is empty');
     }
     if (typeof rawTransaction === 'string') {
-      if (/^0x?[0-9a-f]{1,}$/.test(rawTransaction.toLowerCase())) {
+      if (RAW_TX_HEX_REGEX.test(rawTransaction.toLowerCase())) {
         const txBytes = ethUtil.toBuffer(ethUtil.addHexPrefix(rawTransaction.toLowerCase()));
         if (!this.isEip1559Txn(txBytes) && !this.isRLPDecodable(txBytes)) {
           throw new ParseTransactionError('There was error in decoding the hex string');

modules/abstract-lightning/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitgo/abstract-lightning",
-  "version": "7.0.0",
+  "version": "0.0.0-semantic-release-managed",
   "description": "BitGo SDK coin library for base Lightning Network coin implementation",
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
@@ -40,9 +40,10 @@
   },
   "dependencies": {
     "@bitgo/public-types": "5.22.0",
-    "@bitgo/sdk-core": "^36.8.0",
-    "@bitgo/statics": "^57.8.0",
-    "@bitgo/utxo-lib": "^11.10.0",
+    "bip174": "npm:@bitgo-forks/bip174@3.1.0-master.4",
+    "@bitgo/sdk-core": "0.0.0-semantic-release-managed",
+    "@bitgo/statics": "0.0.0-semantic-release-managed",
+    "@bitgo/utxo-lib": "0.0.0-semantic-release-managed",
     "bs58check": "^2.1.2",
     "fp-ts": "^2.12.2",
     "io-ts": "npm:@bitgo-forks/io-ts@2.1.4",

modules/abstract-lightning/src/codecs/api/withdraw.ts

@@ -1,6 +1,7 @@
 import * as t from 'io-ts';
 import { LightningOnchainRequest, optionalString } from '@bitgo/public-types';
 import { PendingApprovalData, TxRequestState } from '@bitgo/sdk-core';
+import { Bip32Derivation } from 'bip174/src/lib/interfaces';
 
 export const WithdrawStatusDelivered = 'delivered';
 export const WithdrawStatusFailed = 'failed';
@@ -124,3 +125,10 @@ export const SendPsbtResponse = t.intersection(
   'SendPsbtResponse'
 );
 export type SendPsbtResponse = t.TypeOf<typeof SendPsbtResponse>;
+
+export type WithdrawBaseOutputUTXO<TNumber extends number | bigint = number> = {
+  value: TNumber;
+  change: boolean;
+  address: string;
+  bip32Derivation?: Bip32Derivation;
+};

modules/abstract-lightning/src/lightning/index.ts

@@ -1,3 +1,4 @@
 export * from './signableJson';
 export * from './signature';
 export * from './lightningUtils';
+export * from './parseWithdrawPsbt';