Various fixes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added github actions for shellcheck Made devcontainer.sh comply to shellcheck standards Added logic to devcontainer.sh to change user id and group id Added logic to replace the variables in devcontainer.json Added long option for docker run OPTIONS
…soft.com/vscode/devcontainers/base:alpine-3.12" image has it owned by 1000?
OhMyMndy
commented
Feb 2, 2021
devcontainer.sh
Outdated
| if [[ '$REMOTE_USER' != '' ]] && command -v usermod &>/dev/null; \ | ||
| then \ | ||
| sudo='' | ||
| if [[ "$(stat -f -c '%u' $(which sudo))" = '0' ]]; then |
Author
There was a problem hiding this comment.
For some reason the mcr.microsoft.com/vscode/devcontainers/base:alpine-3.12 image has sudo owned by 1000 and therefore it cannot be used as root
OhMyMndy
commented
Feb 2, 2021
| PGID=$(id -g) | ||
|
|
||
| # shellcheck disable=SC2086 | ||
| docker run -it $DOCKER_OPTS $PORTS $ENVS $MOUNT -w "$WORK_DIR" "$DOCKER_TAG" "$SHELL" -c "\ |
Author
There was a problem hiding this comment.
I run it like this: .devcontainer.sh -v --docker-opts="-u root"
|
ping @BorisWilhelms - is there a chance of review (merging/rejecting/commenting)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker rundevcontainer.jsondevcontainer.jsonwhich has comments and trailing comma's in it to test withdevcontainer.json(localWorkspaceFolderBasename and localWorkspaceFolder for now)chmod+chownwhen starting, just like Vs Code does