Fix editor crash when missing required project directories#67
Merged
WireWhiz merged 5 commits intoBraneReality:Mainfrom Sep 17, 2025
Merged
Fix editor crash when missing required project directories#67WireWhiz merged 5 commits intoBraneReality:Mainfrom
WireWhiz merged 5 commits intoBraneReality:Mainfrom
Conversation
rgnter
commented
Sep 16, 2025
|
|
||
| _fileWatcher = std::make_unique<FileWatcher>(); | ||
| _fileWatcher->loadCache(projectDirectory() / "cache" / "changeCache"); | ||
| _fileWatcher->loadCache(projectDirectory() / "cache" / "changeCache.bin"); |
Contributor
Author
There was a problem hiding this comment.
This will break existing caches but it's clearer that this is a binary cache file, would you like to keep this?
Collaborator
There was a problem hiding this comment.
I'm not worried about breaking changes at all until we release a LTS version. I prefer the more descriptive name
rgnter
force-pushed
the
fix/editor-path-crash
branch
from
f40471f to
804cbd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes some other required fixes I had to make to have the project compile. Please review on commit-by-commit basis.