-
Notifications
You must be signed in to change notification settings - Fork 12
Fix editor crash when missing required project directories #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6b541e7
set vcpkg repository baseline
rgnter 733a7d2
fix compilation error because of missing chrono header include
rgnter 9b2582a
editor assets source list only requires translation units
rgnter 5353910
brane editor install target binary
rgnter 804cbd8
Fix brane editor crash accessing required default project directories
rgnter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,15 @@ | ||
| find_package(jsoncpp CONFIG REQUIRED) | ||
|
|
||
| set(CMAKE_FOLDER ${CMAKE_FOLDER}/Assets) | ||
| add_library(editorAssets STATIC | ||
| gltfLoader.cpp | ||
| assemblyBuilder.cpp | ||
| editorAsset.cpp | ||
| types/editorShaderAsset.cpp | ||
| types/editorAssemblyAsset.cpp | ||
| jsonVirtualType.cpp assetCache.cpp assetCache.h types/editorMaterialAsset.cpp types/editorMaterialAsset.h types/editorChunkAsset.cpp types/editorChunkAsset.h assemblyReloadManager.cpp assemblyReloadManager.h types/editorImageAsset.cpp types/editorImageAsset.h) | ||
| jsonVirtualType.cpp | ||
| assetCache.cpp | ||
| types/editorMaterialAsset.cpp | ||
| types/editorChunkAsset.cpp | ||
| assemblyReloadManager.cpp | ||
| types/editorImageAsset.cpp) | ||
| target_link_libraries(editorAssets PUBLIC assets_client ecs JsonCpp::JsonCpp) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,27 @@ | ||
| { | ||
| "dependencies": [ | ||
| "openssl", | ||
| "asio", | ||
| "cpp-httplib", | ||
| "gtest", | ||
| "jsoncpp", | ||
| "sqlite3", | ||
| "shaderc", | ||
| "spirv-cross", | ||
| "glm", | ||
| "vulkan", | ||
| "glfw3", | ||
| { | ||
| "name": "imgui", | ||
| "features": [ | ||
| "docking-experimental", | ||
| "glfw-binding", | ||
| "vulkan-binding" | ||
| ] | ||
| }, | ||
| "imguizmo", | ||
| "tinyfiledialogs", | ||
| "stb" | ||
| ] | ||
| "dependencies": [ | ||
| "openssl", | ||
| "asio", | ||
| "cpp-httplib", | ||
| "gtest", | ||
| "jsoncpp", | ||
| "sqlite3", | ||
| "shaderc", | ||
| "spirv-cross", | ||
| "glm", | ||
| "vulkan", | ||
| "glfw3", | ||
| { | ||
| "name": "imgui", | ||
| "features": [ | ||
| "docking-experimental", | ||
| "glfw-binding", | ||
| "vulkan-binding" | ||
| ] | ||
| }, | ||
| "imguizmo", | ||
| "tinyfiledialogs", | ||
| "stb" | ||
| ], | ||
| "builtin-baseline": "5a5662402382b1aa72f64440717b75258992eba0" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break existing caches but it's clearer that this is a binary cache file, would you like to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not worried about breaking changes at all until we release a LTS version. I prefer the more descriptive name