Conversation
|
You want to put the reference to the main repo PR in the title to trigger the CI check there. Which I realize is not clear from the README at present. |
|
@speth ... I decided against moving on the license file, and focus on updates of instructions instead. The procedure in #3 was not clear, and I don't think that there's a way for the CI to pull in the updated input file (which only exist in a user's personal fork) into the submodule as previously described (the Linter action works, but the example runners fail as they are not aware of the input file). |
cd8ff4e to
37af11f
Compare
The CI on Cantera/cantera pulls in the updated input files from the PR to this repository using the GitHub CLI, which can figure out the correct fork to fetch from. You can see where this happens in a run for Cantera/cantera#1887 here: https://github.com/Cantera/cantera/actions/runs/17043712679/job/48351760292. None of the cases that run the examples nor the one that builds the docs would have succeeded if that wasn't the case. I think the reason it doesn't work here is because the checkout of git clone https://github.com/cantera/cantera-example-data --depth 1 example-data-test
cd example-data-test
gh pr checkout --repo Cantera/cantera-example-data 4whereas without the I think this would work if you opened the PR from your fork of |
Ah - looks like I forgot to fork this! I apparently clarified this in the instructions despite failing to do this myself. Let me try again ... PS: reopened as #5. |
silicon_carbide.yamlto make the naming convention consistent within this repo: all others use kebab-style.References Cantera/cantera#1951
Note: earlier versions of this PR included a new license file, but I decided to defer this addition and focus on clarifying the
README.mdfile instead.