Two-Term Boltzmann Equation solver#1887
Conversation
|
Thank you very much for your interest in our work. The modifications you introduced in this branch are still under active development in our labs (see the latest developments in the second part of this message). To make all of our efforts as efficient as possible, it would be helpful to coordinate our developments. What are the current targets of your branch in terms of features and time of integration in the main version? In particular we are working on a plasma reactor that can reproduce detailed plasma assisted combustion simulations. Are you also interested in that feature? Please see an example of application in this paper:. In brief, the plasma reactor is solving traditional 0-dimensional reactor equations with an additional energy equation for vibrational species which is important for PAC simulations. You can find first results with the last developments, which is one of the simulations presented in Ignition enhancement and NOx formation of NH3/air mixtures by non-equilibrium plasma discharge. It is compared to one of our previous in-house cantera versions based on cantera 2.3 (see here for code presentation). For now, we capture pretty well the fast-gas heating as well as the resulting partial ammonia oxidation despite minor differences in governing equations between the two implementations. The latest is expected to be more conservative and generic in terms of energy balance. As a reminder of what has already been published on our original issue, the latest developments made on the PlasmaReactor from @NicolasBarleon, @qumale and @BangShiuh done by @Gaetanosaure (PhD student of Antonio Andreini and of Nicolas Barléon) currently present the features described below. It can be found: here
Should you have any questions on those new developments, please contact @NicolasBarleon or @Gaetanosaure. We are very much looking forward to working with you on our plasma module development. It would most likely be useful to set up a meeting so that we can understand our respective goals. We could send you a poll to check our respective availabilities (@mquiram you can get in touch by email with barleon@cerfacs.fr and bizot@cerfacs.fr). If that makes integration easier, we could be willing to continue our development on the current issue that you recently created. Kind regards, Nicolas Barléon and Gaétan Bizot |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 74.87% 74.97% +0.09%
==========================================
Files 448 450 +2
Lines 55740 56248 +508
Branches 9195 9301 +106
==========================================
+ Hits 41736 42172 +436
- Misses 10901 10940 +39
- Partials 3103 3136 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@mquiram ... thank you for the PR. I have a minor suggestion:
This change incorporates a Two-Term Boltzmann Equation solver primarily written by @QuentinMale and @NicolasBarleon from the branch https://github.com/QuentinMale/canteraBS/tree/canteraPlasma
Included python example of solver comparison with BOLOS: plasmatest.py (by @QuentinMale and @NicolasBarleon), and a time evolving E/N reactor example: nanosecondPulse.py
Could you please move those comments into the corresponding git commit messages?
|
@ischoegl - My plan is to do a little bit of history rewriting on this so that the code written by other authors is separated into commits attributed to them. |
a14fdb5 to
953d866
Compare
There was a problem hiding this comment.
I see that this PR contains several large YAML input files. @speth ... should these go into https://github.com/Cantera/cantera-example-data?
Yes. I'm trying to refactor several aspects of this PR to fit better with existing capabilities and conventions. I will request a review when this is actually ready. |
2d877e3 to
b43e7b9
Compare
…d warning in PlasmaPhase
…mple, reversed changes to pfr example, and addressed CI build docs and LLVM errors
ischoegl
left a comment
There was a problem hiding this comment.
Thanks everyone for this PR! I had a look over this and only have one trivial suggestion. Using the C++ Gaussian1 would make this run a little faster as it doesn't require Python callbacks.


Changes proposed in this pull request
Cantera/enhancements#194
Closes #
Included python example of solver comparison with BOLOS: plasmatest.py (by @QuentinMale and @NicolasBarleon), and a time evolving E/N reactor example: nanosecondPulse.py
Checklist
scons build&scons test) and unit tests address code coverage