Skip to content

Add expand_only option to SEQopts to return expanded dataset without running full analysis#46

Merged
remlapmot merged 3 commits intomainfrom
devel-2026-04-27
Apr 30, 2026
Merged

Add expand_only option to SEQopts to return expanded dataset without running full analysis#46
remlapmot merged 3 commits intomainfrom
devel-2026-04-27

Conversation

@remlapmot
Copy link
Copy Markdown
Contributor

Adding the same option as per today's SEQTaRget PR.

@remlapmot remlapmot requested a review from ryan-odea April 27, 2026 12:50
Copy link
Copy Markdown
Collaborator

@ryan-odea ryan-odea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit mixed on including this in the python version - I suppose it is not bad to include additional options to the user. It's not too difficult to inspect the class object after expansion has been applied (collect should be able to handle this at any time).

Wondering about your thoughts?

@remlapmot
Copy link
Copy Markdown
Contributor Author

I was just trying to keep the R and Python packages with approx the same options.

One difference/benefit this gives beyond skipping the computation: in expand_only mode the protocol-censoring step (_dynamic) is also skipped, so the returned DT is the raw expansion — which you can't get by just reading s.DT after a normal expand().

We already have plenty of options, so one more doesn't add much overhead.

So I'm still in favour of this.

@remlapmot remlapmot merged commit dee8192 into main Apr 30, 2026
5 checks passed
@remlapmot remlapmot deleted the devel-2026-04-27 branch April 30, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants