Skip to content

Modified excluded engine type for agent Visual Studio (AST-110820) #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Modified excluded engine type for agent Visual Studio (AST-110820) #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94dca7e
modified excluded engine type for agent Visual Studio
cx-rah-pid Aug 29, 2025
ea11e39
fixed resubmit scs issue
cx-rah-pid Sep 10, 2025
db61f76
Merge branch 'main' into feature/AST-110820
cx-rah-pid Sep 11, 2025
b132850
Merge branch 'main' into feature/AST-110820
cx-rah-pid Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/commands/result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,7 @@ func filterScsResultsByAgent(results *wrappers.ScanResultsCollection, agent stri
commonParams.VSCodeAgent: {commonParams.SCSScorecardType},
commonParams.JetbrainsAgent: {commonParams.SCSScorecardType},
commonParams.EclipseAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
commonParams.VisualStudioAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
commonParams.VisualStudioAgent: {commonParams.SCSScorecardType},
}

excludedTypes := make(map[string]struct{})
Expand Down
48 changes: 48 additions & 0 deletions internal/commands/result_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,54 @@ func TestRunNilResults_Other_AgentsShouldNotShowAnyResults(t *testing.T) {
removeFileBySuffix(t, printer.FormatJSON)
}

func TestRunScsResultsShow_Other_AgentShouldShowSCSResults(t *testing.T) {
clearFlags()
mock.HasScs = true
mock.ScsScanPartial = false
mock.ScorecardScanned = true
mock.Flag = wrappers.FeatureFlagResponseModel{Name: wrappers.SCSEngineCLIEnabled, Status: true}

execCmdNilAssertion(t, "results", "show", "--scan-id", "SCS_ONLY", "--report-format", "json", "--agent", params.VisualStudioAgent)
assertTypePresentJSON(t, params.SCSScorecardType, 0)
assertTypePresentJSON(t, params.SCSSecretDetectionType, 2)
assertTotalCountJSON(t, 2)

removeFileBySuffix(t, printer.FormatJSON)
mock.SetScsMockVarsToDefault()
}

func TestFilterScsResultsByAgent_ShouldIncludeSCSAndSAST(t *testing.T) {
results := &wrappers.ScanResultsCollection{
Results: []*wrappers.ScanResult{
{Type: params.SCSScorecardType},
{Type: params.ScsType},
{Type: params.SastType},
},
}

filteredResults := filterScsResultsByAgent(results, params.VisualStudioAgent)

hasSCS := false
hasSCSScorecard := false
hasSAST := false

for _, result := range filteredResults.Results {
switch result.Type {
case params.ScsType:
hasSCS = true
case params.SCSScorecardType:
hasSCSScorecard = true
case params.SastType:
hasSAST = true
}
}

assert.Assert(t, hasSCS, "Expected SCS type to be included for Visual Studio agent")
assert.Assert(t, !hasSCSScorecard, "Expected SCSScorecard type to be excluded for Visual Studio agent")
assert.Assert(t, hasSAST, "Expected SAST type to be excluded for Visual Studio agent")
assert.Equal(t, len(filteredResults.Results), 2, "Expected 2 results (SCS and SAST) after filtering for Visual Studio agent")
}

func TestResultsExitCode_OnCanceledScan_PrintOnlyScanIDAndStatusCanceledToConsole(t *testing.T) {
model := wrappers.ScanResponseModel{
ID: "fake-scan-id-kics-fail-sast-canceled-id",
Expand Down
Loading