Fix distributed HydrostaticFreeSurfaceModel test that seem to break with memory error#4666
Merged
simone-silvestri merged 8 commits intomainfrom Jul 28, 2025
Merged
Conversation
navidcy
added
testing 🧪
Member
Author
|
Hm... this tho passed: https://buildkite.com/clima/oceananigans-distributed/builds/9100#0198392b-7d42-48c3-994f-3695c482b433 So perhaps the errors are random/stochastic... |
Collaborator
|
Yeah, I think it is kind of random, it might be connected to the timeout of the yaml. Let me try changing it. |
Member
Author
Member
Author
|
I increased the memory request a bit. They passed the first go. Shall we merge? Does it worth more investigating? |
Collaborator
|
Let's merge this then see if the error continues appearing |
simone-silvestri
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See, e.g., CI failing at https://buildkite.com/clima/oceananigans-distributed/builds/9099#01983929-93d5-40da-807c-a285722c8701