Skip to content

Fix distributed HydrostaticFreeSurfaceModel test that seem to break with memory error #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simone-silvestri merged 8 commits into from
Jul 28, 2025
Merged

Fix distributed HydrostaticFreeSurfaceModel test that seem to break with memory error #4666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ab408f
add some debug statements
navidcy Jul 23, 2025
6329356
Update test_distributed_hydrostatic_model.jl
navidcy Jul 24, 2025
d41b057
impose a larger timeout
simone-silvestri Jul 24, 2025
32b48a8
Update pipeline.yml
simone-silvestri Jul 25, 2025
461b5f4
Update test_distributed_hydrostatic_model.jl
navidcy Jul 25, 2025
802a46d
Merge branch 'main' into ncc/distributed-hydrostaticmodel-tests
navidcy Jul 25, 2025
fa70ea0
Merge branch 'main' into ncc/distributed-hydrostaticmodel-tests
navidcy Jul 26, 2025
9201794
Update pipeline.yml
navidcy Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .buildkite/distributed/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ steps:
TEST_ARCHITECTURE: "CPU"
commands:
- "srun julia -O0 --color=yes --project -e 'using Pkg; Pkg.test()'"
timeout_in_minutes: 1440
agents:
slurm_mem: 50G
slurm_ntasks: 4
Expand All @@ -112,8 +113,9 @@ steps:
TEST_ARCHITECTURE: "GPU"
commands:
- "srun julia -O0 --color=yes --project -e 'using Pkg; Pkg.test()'"
timeout_in_minutes: 1440
agents:
slurm_mem: 80G # Apparently the GPU tests require more memory
slurm_mem: 100G # Apparently the GPU tests require more memory
slurm_ntasks: 4
slurm_gpus_per_task: 1
retry:
Expand Down
5 changes: 4 additions & 1 deletion test/test_distributed_hydrostatic_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ for arch in archs
arch = synchronized(arch)
closure = CATKEVerticalDiffusivity()

if arch.local_rank == 0
@info " Testing CATKE with $(ranks(arch)) ranks"
end

# "s" for "serial" computation, "p" for parallel
ms = rotation_with_shear_test(global_underlying_grid, closure)
mp = rotation_with_shear_test(underlying_grid, closure)
Expand Down Expand Up @@ -188,4 +192,3 @@ for arch in archs
end
end
end

Loading