refactor(decompose sample file formatter)#3960
Merged
ChrOertlin merged 6 commits intomasterfrom Nov 25, 2024
Merged
Conversation
islean
approved these changes
Nov 21, 2024
Member
islean
left a comment
islean
left a comment
There was a problem hiding this comment.
Looks good! I wonder if we can get the benefits from the dependency injection and use default values or if that defeats the added clarity in what is needed.
cg/services/deliver_files/deliver_files_service/deliver_files_service_factory.py
Show resolved
Hide resolved
cg/services/deliver_files/deliver_files_service/deliver_files_service_factory.py
Show resolved
Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py
Outdated
Show resolved
Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py
Outdated
Show resolved
Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py
Outdated
Show resolved
Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_concatenation_service.py
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decompose the logic in the SampleFileFormatter into smaller modules.
The extraction of the logic into smaller modules is also beneficial for this issue: #3910 as some functionality is needed there as well
Part of #3916
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan