Switch from abstract classes to protocols with generic types#4797
Draft
Switch from abstract classes to protocols with generic types#4797
Conversation
|
diitaz93
reviewed
Jan 13, 2026
Comment on lines
+13
to
+17
| RunDataT_contra = TypeVar("RunDataT_contra", bound=RunData, contravariant=True) | ||
| RunDataT_co = TypeVar("RunDataT_co", bound=RunData, covariant=True) | ||
|
|
||
| class RunDataGenerator(ABC): | ||
| RunMetricsT_co = TypeVar("RunMetricsT_co", bound=RunMetrics, covariant=True) | ||
|
|
Contributor
There was a problem hiding this comment.
This is not clear to me, could we discuss it in coding guidelines if there is time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan