Skip to content

Patch post processing error raising#4849

Open
islean wants to merge 4 commits intomasterfrom
patch-zipped-reports-check
Open

Patch post processing error raising#4849
islean wants to merge 4 commits intomasterfrom
patch-zipped-reports-check

Conversation

@islean
Copy link
Member

@islean islean commented Jan 22, 2026

Description

The post processing currently raises a list index out of bounds error rather than a file not found error when no zipped reports folder is found. The intent seems to be that we should raise the former, which would allow us to not exit early. This PR fixes that.

Added

Changed

Fixed

  • A file not found error is raised if no zipped reports folder is found for a SMRT cell when post processing a run

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean marked this pull request as ready for review January 22, 2026 14:27
@islean islean requested a review from a team as a code owner January 22, 2026 14:27
Copy link
Contributor

@RasmusBurge-CG RasmusBurge-CG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants