Skip to content

Validate no relationships#4874

Merged
islean merged 15 commits intomasterfrom
validate-no-relationships
Feb 16, 2026
Merged

Validate no relationships#4874
islean merged 15 commits intomasterfrom
validate-no-relationships

Conversation

@islean
Copy link
Member

@islean islean commented Feb 4, 2026

Description

Closes #4859.

Added

  • Validation rule preventing samples not related to other samples in the same case in RD and MIP-DNA orders.

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage February 4, 2026 15:49 Inactive
@islean
Copy link
Member Author

islean commented Feb 4, 2026

Two samples with no relationships specified:

image

Existing case with no relationships specified:

image

Existing case with one isolated sample:

image

Existing case which is valid:

image

@clingen-sthlm clingen-sthlm temporarily deployed to stage February 5, 2026 15:08 Inactive
@islean islean marked this pull request as ready for review February 5, 2026 15:22
@islean islean requested a review from a team as a code owner February 5, 2026 15:22
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sonarqubecloud
Copy link

@islean islean merged commit d27240b into master Feb 16, 2026
10 checks passed
@islean islean deleted the validate-no-relationships branch February 16, 2026 14:54
@islean
Copy link
Member Author

islean commented Feb 16, 2026

Deployed to the VMs and Hasta:

Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/isak.ohlsson
done.
Log deploy... done.
cg, version 84.1.0
...
/home/isak.ohlsson
INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
[isak.ohlsson@hasta:~] [P_base] $ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add validation to prevent ordering mip analyses of samples without relationships

3 participants