Skip to content

Improve readability in the admin view for Read and HiFi Yield#4877

Merged
RasmusBurge-CG merged 15 commits intomasterfrom
improved-yield-view
Feb 16, 2026
Merged

Improve readability in the admin view for Read and HiFi Yield#4877
RasmusBurge-CG merged 15 commits intomasterfrom
improved-yield-view

Conversation

@RasmusBurge-CG
Copy link
Contributor

@RasmusBurge-CG RasmusBurge-CG commented Feb 5, 2026

Description

Closes: https://github.com/Clinical-Genomics/ProdBioInfo/issues/246

Added

  • Comma separation for large numbers on Reads in Sample table in the Admin view:

100,000,000
100,000
100
1

  • SI prefix on Hifi Yield in the Sample table in the Admin view :

1.00 Tb
1.00 Gb
1.00 Mb
1.00 kb
1b

(b-base pairs)

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b improved-yield-view -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage February 5, 2026 16:17 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage February 6, 2026 11:03 Inactive
@RasmusBurge-CG RasmusBurge-CG changed the title Improve readability for Read and hifi yield Improve readability the Admin view for Read and hifi yield Feb 6, 2026
@RasmusBurge-CG RasmusBurge-CG changed the title Improve readability the Admin view for Read and hifi yield Improve readability in the admin view for Read and HiFi Yield Feb 6, 2026
@RasmusBurge-CG
Copy link
Contributor Author

Screenshot 2026-02-09 at 15 56 59

@StellaPaulina
Copy link

Very nice! I would second that suggestion to try spaced for the same reason as Alfred unless it will take too much space on the row

@RasmusBurge-CG
Copy link
Contributor Author

RasmusBurge-CG commented Feb 10, 2026

Very nice! I would second that suggestion to try spaced for the same reason as Alfred unless it will take too much space on the row

Hi!
I tried that, and with the current implementation, it would occasionally produce a line break.
It would render like this:
100
000
000
Instead of like this:
100 000 000

@StellaPaulina How would you like to proceed? Is it okay with a comma or is it a dealbreaker?

@dnil
Copy link
Member

dnil commented Feb 10, 2026

We had a similar discussion with Scout, and ended up with thinsp thin spaces for spacing plus a copy button to make it smooth to copy and use the numbers as such. Since there are all kinds of local national standards for making numbers readable, adding commas, points and apostrophes is bound to backfire at some point. 😊 I take the Indian numbering system as a case in point "3,00,00,000" (https://en.wikipedia.org/wiki/Indian_numbering_system)

@RasmusBurge-CG
Copy link
Contributor Author

@dnil I see, good point. I will leave some options to prod.

Option 1
Screenshot 2026-02-10 at 15 18 16

Option 2
Screenshot 2026-02-10 at 15 12 12

Option 3
Screenshot 2026-02-10 at 15 15 37

Option 4
Leave it as it is

@RasmusBurge-CG
Copy link
Contributor Author

Option 1 was selected, discussion open office 2026-02-10
image

@RasmusBurge-CG RasmusBurge-CG marked this pull request as ready for review February 10, 2026 14:28
@RasmusBurge-CG RasmusBurge-CG requested a review from a team as a code owner February 10, 2026 14:28
@dnil
Copy link
Member

dnil commented Feb 10, 2026

Ajajaj. Oh well, too late, you can't argue with office democracy. Next time, just silently follow the SI / NIST, and consider text-nowrap or white-space:nowrap. 😁

@RasmusBurge-CG
Copy link
Contributor Author

RasmusBurge-CG commented Feb 11, 2026

Ajajaj. Oh well, too late, you can't argue with office democracy. Next time, just silently follow the SI / NIST, and consider text-nowrap or white-space:nowrap. 😁

Thanks, Daniel, very helpful.
Could I ask the reviewer to consider this and help me navigate the tricky waters.

@clingen-sthlm clingen-sthlm temporarily deployed to stage February 14, 2026 13:31 Inactive
Copy link
Member

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

RasmusBurge-CG and others added 4 commits February 16, 2026 09:52
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@sonarqubecloud
Copy link

Copy link
Member

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RasmusBurge-CG RasmusBurge-CG merged commit 72754f2 into master Feb 16, 2026
10 checks passed
@RasmusBurge-CG RasmusBurge-CG deleted the improved-yield-view branch February 16, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants