Skip to content

Development #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
padrewin merged 4 commits into from
Feb 4, 2025
Merged

Development #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb59750
Update pom.xml
padrewin Feb 4, 2025
f600688
Update ToggleCommand.java
padrewin Feb 4, 2025
919e4f5
Update Confirm2Drop.java
padrewin Feb 4, 2025
37c61ed
Update DropListener.java
padrewin Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>dev.padrewin</groupId>
<artifactId>confirm2drop</artifactId>
<version>1.4</version>
<version>1.4.1</version>
<packaging>jar</packaging>

<name>confirm2drop</name>
Expand Down Expand Up @@ -119,7 +119,7 @@
<dependency>
<groupId>dev.padrewin</groupId>
<artifactId>colddev</artifactId>
<version>1.4.7</version>
<version>1.4.8</version>
<scope>compile</scope>
</dependency>

Expand Down
13 changes: 7 additions & 6 deletions src/main/java/dev/padrewin/confirm2Drop/Confirm2Drop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,13 @@ protected List<ColdSetting<?>> getColdConfigSettings() {
@Override
protected String[] getColdConfigHeader() {
return new String[] {
" ____ ___ _ ____ ",
" / ___|/ _ \\ | | | _ \\ ",
"| | | | | || | | | | | ",
"| |___| |_| || |___ | |_| | ",
" \\____|\\___/ |_____|_____/ ",
" "
" ██████╗ ██████╗ ██╗ ██████╗ ",
"██╔════╝██╔═══██╗██║ ██╔══██╗",
"██║ ██║ ██║██║ ██║ ██║",
"██║ ██║ ██║██║ ██║ ██║",
"╚██████╗╚██████╔╝███████╗██████╔╝",
" ╚═════╝ ╚═════╝ ╚══════╝╚═════╝ ",
" "
};
}

Expand Down
1 change: 0 additions & 1 deletion src/main/java/dev/padrewin/confirm2Drop/commands/ToggleCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import dev.padrewin.colddev.utils.StringPlaceholders;
import dev.padrewin.confirm2Drop.Confirm2Drop;
import dev.padrewin.confirm2Drop.listeners.DropListener;
import dev.padrewin.confirm2Drop.manager.CommandManager;
import dev.padrewin.confirm2Drop.manager.LocaleManager;
import org.bukkit.command.CommandSender;
Expand Down
6 changes: 0 additions & 6 deletions src/main/java/dev/padrewin/confirm2Drop/listeners/DropListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ private void dropItemToGround(Player player, ItemStack item) {
private void requestConfirmation(Player player, ItemStack item) {
UUID playerUUID = player.getUniqueId();

if (isInventoryFull(player)) {
debug("Player " + player.getName() + "'s inventory is full. Dropping item to the ground.");
dropItemToGround(player, item);
return;
}

pendingConfirmation.put(playerUUID, item.clone());

int timeoutSeconds = plugin.getConfig().getInt("confirmation-timeout", 10);
Expand Down