fix: prevent panic on UTF-8 multi-byte characters in slice preview#230
Open
x19216888-stack wants to merge 1 commit intoCortexLM:mainfrom
Open
fix: prevent panic on UTF-8 multi-byte characters in slice preview#230x19216888-stack wants to merge 1 commit intoCortexLM:mainfrom
x19216888-stack wants to merge 1 commit intoCortexLM:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cortex importpanics withbyte index is not a char boundaryif a multi-byte UTF-8 character appears exactly around the 200-byte error preview truncation mark. This PR changes the slice truncation to evaluate againstchars().take(200)correctly.Bounty Eligibility
bounty-cliSS58 registry once merged and labeled.Verification
Generated test file with
e-acute (U+00E9)crossing the 200th byte and rancortex import. The process correctly delegates gracefully to the JSON parser output instead of process abortation (core dumped).