Skip to content

fix: prevent panic on UTF-8 multi-byte characters in slice preview #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x19216888-stack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent panic on UTF-8 multi-byte characters in slice preview #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cortex-cli/src/import_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ impl ImportCommand {
// Parse the export with helpful error messages
let export: SessionExport = serde_json::from_str(&json_content).map_err(|e| {
// Create a helpful error message with content preview
let preview_len = json_content.len().min(200);
let content_preview = &json_content[..preview_len];
let truncated = if json_content.len() > 200 {
let content_preview: String = json_content.chars().take(200).collect();
let preview_len = content_preview.len();
let truncated = if json_content.chars().count() > 200 {
"..."
} else {
""
Expand Down