Skip to content

Community group page detail#654

Open
secondaryfun wants to merge 50 commits intodevelopfrom
community-group-page-detail
Open

Community group page detail#654
secondaryfun wants to merge 50 commits intodevelopfrom
community-group-page-detail

Conversation

@secondaryfun
Copy link
Copy Markdown
Contributor

  • Added dropdown selector for groups.
  • Now populating the following from state:
    ** Title
    ** Post
    ** Comments
    ** Description
    ** Members
  • Is the feature complete/bug resolved/etc..:

Features remaining to add as issues:
** View upcoming events for the group.
** View group media.
** Replies to comments
** Add comments via button
** Add likes to posts or comments

  • Any known bugs/strange behavior:
  • Currently, the group detail is set statically.
  • Is there specific feedback you would like on these changes:

  • Screenshot(s):
    image

Copy link
Copy Markdown
Contributor

@0xZakk 0xZakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secondaryfun Really impressive work here! This looks really good! See my feedback below

Comment thread client/src/components/Comment/Comment.js Outdated
Comment thread client/src/components/Comment/Comment.js Outdated
Comment thread client/src/components/ForumPost/ForumPost.js Outdated
Comment thread client/src/components/ForumPostContainer/ForumPostContainer.js Outdated
Comment thread client/src/components/InputSelect/InputSelect.js Outdated
Comment thread client/src/components/NavLink/NavLink.js Outdated
Comment thread client/src/pages/CommunityPage/CommunityPageGroup.js Outdated
Comment thread client/src/pages/CommunityPage/CommunityPageGroup.js
Comment thread client/src/pages/CommunityPage/CommunityPageGroup.js Outdated
Comment thread client/src/pages/CommunityPage/CommunityPageGroup.js Outdated
@secondaryfun secondaryfun requested a review from 0xZakk July 9, 2020 17:48
@secondaryfun secondaryfun requested a review from 0xZakk July 13, 2020 22:45
Copy link
Copy Markdown
Contributor

@0xZakk 0xZakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secondaryfun @MilesHamilton

Getting the following error when I try to go to the explore-people page:

image

Getting a lot of other errors too. Can you go through and double check everything is working before requesting another revew?

@MilesHamilton
Copy link
Copy Markdown
Contributor

@secondaryfun waiting on a PR review from @Underwaterr after that you should be able to pull from develop to update that page or you could pull directly from community-group-detail-search which is updated as well

@secondaryfun
Copy link
Copy Markdown
Contributor Author

Hopefully its working now. I identified an issue with the nav-bar, which fails to load a placeholder image, but i'll address that in a separate issue.

@secondaryfun secondaryfun requested a review from 0xZakk July 14, 2020 16:01
Copy link
Copy Markdown
Contributor

@0xZakk 0xZakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secondaryfun Can you test to make sure everything is working before requesting a review?

@secondaryfun secondaryfun requested a review from 0xZakk July 14, 2020 19:28
@secondaryfun
Copy link
Copy Markdown
Contributor Author

Changes to the Member-Page are simply to make the placeholder data work with the correct settings on my component app.

This was referenced Jul 15, 2020
Copy link
Copy Markdown
Contributor

@0xZakk 0xZakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we can merge, fix issue with loading group detail page

@secondaryfun secondaryfun requested a review from 0xZakk July 15, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants