ALE driver verification script addition#584
Merged
antonhibl merged 27 commits intoDOI-USGS:mainfrom Mar 6, 2024
Merged
Conversation
acpaquette
reviewed
Jan 8, 2024
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 15.14% 14.81% -0.33%
==========================================
Files 58 59 +1
Lines 6563 6709 +146
==========================================
Hits 994 994
- Misses 5569 5715 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ad in a PVLModule
…ested and run against to find one that works. there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
acpaquette
reviewed
Mar 6, 2024
Collaborator
acpaquette
left a comment
acpaquette
left a comment
There was a problem hiding this comment.
Overall looks good, couple of things to address then this can get merged
acpaquette
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:
This adds a script for driver verification wherein a image is run through both ALE and ISIS and then compared to see how different ALE drivers compare to ISIS' spiceinit in order to better compare how spice data is utilized through both for image ingestion. An example of it's usage is as follows:
python3 driver_verification.py ClementineIsisLabelNaifSpiceDriver LUA3107H.161.clem.cubOutput will look similar to the following: