Conversation
…or that into the original PR adding it
antonhibl
added a commit
to antonhibl/ale
that referenced
this pull request
Jan 11, 2024
…ad in a PVLModule
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 15.82% 15.81% -0.01%
==========================================
Files 56 56
Lines 6283 6284 +1
==========================================
Hits 994 994
- Misses 5289 5290 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
This PR needs to be based off of main rather than whatever branch it was branched from. Easiest way to do that is to just create a new branch from main and cherry-pick the changes into it |
antonhibl
added a commit
to antonhibl/ale
that referenced
this pull request
Jan 17, 2024
…ested and run against to find one that works. there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #586 and compliments #584 by allowing that verification script to account for these changes which allow PVLModules to be used with ale.load(s).
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: