fix: add validation to importChain to prevent crashes, fixes #12#45
Merged
Dancode-188 merged 1 commit intomainfrom Dec 27, 2025
Merged
fix: add validation to importChain to prevent crashes, fixes #12#45Dancode-188 merged 1 commit intomainfrom
Dancode-188 merged 1 commit intomainfrom
Conversation
importChain would crash when given invalid JSON or when required fields were missing. No try-catch on JSON.parse() and no validation before accessing chain.steps would cause TypeErrors. Added validation for: - JSON parsing errors (wrapped in try-catch) - Required fields: name must be a string - steps must be an array (not undefined/null) Now throws clear errors instead of cryptic TypeErrors when import fails.
Owner
Author
|
Clean validation logic. Error messages are descriptive. Build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Problem
importChain had zero validation. Invalid JSON would crash with JSON.parse() errors, and missing or malformed data would cause TypeErrors when accessing undefined properties.
Changes
Added validation before processing:
Now throws descriptive errors instead of cryptic crashes.