Skip to content

fix: add validation to importChain to prevent crashes, fixes #12 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dancode-188 merged 1 commit into from
Dec 27, 2025
Merged

fix: add validation to importChain to prevent crashes, fixes #12 #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/lib/chain-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,27 @@ class ChainService {
* Import chain from JSON
*/
async importChain(json: string): Promise<Chain> {
const chain = JSON.parse(json) as Chain;

let parsed: any;

try {
parsed = JSON.parse(json);
} catch (error) {
throw new Error('Invalid JSON format');
}

// Validate required fields
if (!parsed || typeof parsed !== 'object') {
throw new Error('Invalid chain data: expected object');
}
if (!parsed.name || typeof parsed.name !== 'string') {
throw new Error('Invalid chain data: name is required');
}
if (!Array.isArray(parsed.steps)) {
throw new Error('Invalid chain data: steps must be an array');
}

const chain = parsed as Chain;

// Generate new IDs
chain.id = `chain-${Date.now()}`;
chain.createdAt = new Date();
Expand Down