fix: use setChainVariables instead of merge for deletion, fixes #39#46
Merged
Dancode-188 merged 2 commits intomainfrom Dec 27, 2025
Merged
fix: use setChainVariables instead of merge for deletion, fixes #39#46Dancode-188 merged 2 commits intomainfrom
Dancode-188 merged 2 commits intomainfrom
Conversation
Chain variable deletion wasn't working because mergeChainVariables merges new variables with existing ones instead of replacing them. When you delete a key and call merge, the deleted key gets added back from the old state. Changed VariablesPanel to use setChainVariables instead, which replaces the entire variable object rather than merging.
The test was expecting the variable to be visible after deletion because deletion wasn't working. Now that deletion works correctly, the test should expect the variable to NOT be visible.
Owner
Author
|
Simple fix with a good catch on the test. The test was a workaround for the broken deletion - now that deletion actually works, the test correctly validates it. CI passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Problem
Deleting chain variables didn't work. The UI would show them gone, but they'd come back on refresh.
Root cause: mergeChainVariables merges the new variables with the old state, so deleted keys get re-added from the old state.
Changes
Use setChainVariables instead of mergeChainVariables when deleting. setChainVariables replaces the entire object, so deletions actually stick.