Skip to content

fix: use setChainVariables instead of merge for deletion, fixes #39 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dancode-188 merged 2 commits into from
Dec 27, 2025
Merged

fix: use setChainVariables instead of merge for deletion, fixes #39 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae18f59
fix: use setChainVariables instead of merge for deletion, fixes #39
Dancode-188 Dec 27, 2025
c022aed
test: fix delete chain variable test to expect not visible
Dancode-188 Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions e2e/tests/main-components/requestBuilder.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ test('add chain variable', async({page, apiReq}) => {

test('delete chain varaible', async({preVariables, apiReq}) => {
await apiReq.chainVariableDelete('chainVar1')
//below test is failing so i have put visisble for now
await expect(apiReq.reqBuilderMain.getByText('chainVar1')).toBeVisible()
await expect(apiReq.reqBuilderMain.getByText('chainVar1')).not.toBeVisible()
})

test('chain variables clear all', async({apiReq, preVariables}) => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/VariablesPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface ConfirmDialog {
}

export default function VariablesPanel() {
const { chainVariables, mergeChainVariables, clearChainVariables } = useStore();
const { chainVariables, mergeChainVariables, setChainVariables, clearChainVariables } = useStore();
const [scriptVariables, setScriptVariables] = useState<Map<string, any>>(new Map());
const [editingKey, setEditingKey] = useState<string | null>(null);
const [editingValue, setEditingValue] = useState<string>('');
Expand Down Expand Up @@ -91,7 +91,7 @@ export default function VariablesPanel() {
if (activeSource === 'chain') {
const newVars = { ...chainVariables };
delete newVars[key];
mergeChainVariables(newVars);
setChainVariables(newVars);
} else {
scriptingService.deleteVariable(key);
loadScriptVariables();
Expand Down