fix --prefix value when using autoconf on windows #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pythyu
approved these changes
Dec 12, 2024
Pythyu
reviewed
Dec 12, 2024
| prefix = options.delete(:prefix) || "#{install_dir}/embedded" | ||
|
|
||
| if windows_target? | ||
| prefix.sub! "C:/", "/c/" |
There was a problem hiding this comment.
❓ Question :
Looks good but to confirm in which way is it replacing ? since I'd expect C:/ path to be the standard on windows and /c/ not working
Author
There was a problem hiding this comment.
Indeed that only work when running the build under msys or similar, definitely not in powershell...
That should be fine since I'm pretty sure autoconf will not work anyway, but I'll double check with the windows team
Author
|
This is actually a leftover from a previous experiment and isn't required anymore. Sorry about this 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when a
Makefiletarget depends on a rule with an absolute path located in the prefix.Since the prefix will contain a
:, this causes syntax errors in the generated Makefiles