Skip to content

fix --prefix value when using autoconf on windows #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chouquette wants to merge 1 commit into from
Closed

fix --prefix value when using autoconf on windows #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/omnibus/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ def configure(*args)
# Accept a prefix override if provided. Can be set to '' to suppress
# this functionality.
prefix = options.delete(:prefix) || "#{install_dir}/embedded"

if windows_target?
prefix.sub! "C:/", "/c/"
Copy link

@Pythyu Pythyu Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Question :
Looks good but to confirm in which way is it replacing ? since I'd expect C:/ path to be the standard on windows and /c/ not working

Copy link
Author

@chouquette chouquette Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed that only work when running the build under msys or similar, definitely not in powershell...
That should be fine since I'm pretty sure autoconf will not work anyway, but I'll double check with the windows team

end
configure_cmd << "--prefix=#{prefix}" if prefix && prefix != ""

configure_cmd.concat args
Expand Down